-
-
Couldn't load subscription status.
- Fork 2.5k
Feature: Added experimental terminal integration #13631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cecddda to
7f8c927
Compare
|
I'm wondering if we can use the conhost from Windows Terminal instead of using the WebView-based terminal? |
|
I'd like to but it's huge and I could not find an easy way to integrate it. |
edf33f7 to
c79b2cb
Compare
32de19b to
ba56951
Compare
|
What's left to do? |
|
Hey @0x5bfa the TODOs I have in mind are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats for the PR, looking forward to use this feature
|
@gave92 Thank you for using CsWin32! This is our short term goal, which is to use source generator everywhere. |
|
I've added a setting under Experimental to enable/disable the feature (default: off). The feature may be good enough for first release :) |
|
I had some notes on this but I'll have another look since it's been a while. |
|
The main point to figure out before merging is whether the terminal is global, or if there can be a separate terminal for each tab & pane. I lean towards the second option (similar to VS Code). |
|
Holding off while @hez2010 checks if it's possible to use Windows Terminal control. |
|
Added ability to have more than one terminal 😇 |
Resolved / Related Issues
Closes Feature: Add terminal Integration #6235
Validation
How did you test these changes?
Screenshots (optional)
